Skip to content
This repository has been archived by the owner on Mar 9, 2022. It is now read-only.

feat: pubsub and ipns pubsub flags #145

Merged
merged 3 commits into from
Oct 27, 2021
Merged

feat: pubsub and ipns pubsub flags #145

merged 3 commits into from
Oct 27, 2021

Conversation

jwh
Copy link
Contributor

@jwh jwh commented Oct 13, 2021

Needed for ipfs/kubo#8510

@jwh jwh changed the title enable pubsub and namesys pubsub to be enable via config enable pubsub and namesys pubsub to be enabled via config Oct 13, 2021
Copy link
Contributor

@aschmahmann aschmahmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR 🙏. Made a few suggested changes. The use of Flag will also mean you'll need to make the relevant changes in the corresponding go-ipfs PR.

pubsub.go Outdated Show resolved Hide resolved
pubsub.go Outdated Show resolved Hide resolved
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making Flag changes. LGTM. 👍
Let's merge this and continue in ipfs/kubo#8510

@lidel lidel changed the title enable pubsub and namesys pubsub to be enabled via config feat: pubsub and ipns pubsub flags Oct 27, 2021
@lidel lidel merged commit 070b449 into ipfs:master Oct 27, 2021
@jwh jwh deleted the pubsubcfg branch October 27, 2021 20:28
@aschmahmann aschmahmann mentioned this pull request Dec 1, 2021
80 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants